Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Auto-fit rows to content #4634

Closed
stratoula opened this issue Mar 11, 2021 · 7 comments
Closed

[EuiDataGrid] Auto-fit rows to content #4634

stratoula opened this issue Mar 11, 2021 · 7 comments

Comments

@stratoula
Copy link
Contributor

Right now, the datagrid doesn't display the entire content if the content is long enough. Here is an example of how it looks on the kibana data table visualization, Discover and Lens.

image

image

image

It seems that this is not so convenient for our users. We would like to have the ability to display multiline rows as for example we could do on the previous implementation of the datatable.

image

@stratoula
Copy link
Contributor Author

cc @flash1293 @kertal

@chandlerprall
Copy link
Contributor

We discussed this as a team and feel there needs to be a larger discussion first to better understand the requirements & rational. Multi-line or otherwise adjustable row heights would introduce a number of UX/UI and technical challenges, and while there are a number of related requests for dynamic heights, it does go against the initial design decisions for the data grid.

@shaunmcgough
Copy link

We (Discover team) are noting a variety of feedback from customers both internal and external about the relative usefulness of the initial state of the data grid in Discover. The most recent here [0]. In general, the sense is that the new view needs to be more useful at first glance, without any other hand movements. One way to get around this is row height in the gird so higher volumes of consumable information appear. We have decided to postpone turning on the data grid by default in 7.13 in part due to this feedback and are now looking for a solution that will unblock the slight regression. The data grid is valuable in so many ways, and the first impression of it here is the key to ensure we add more value with immediate evidence. Ideas welcome and appreciated.

0 - https://discuss.elastic.co/t/discover-table-multi-line-field/271248

. @timroes @kertal @ryankeairns for visibility

@kertal
Copy link
Member

kertal commented Apr 28, 2021

here's an example for data table, showing images https://discuss.elastic.co/t/bug-visualizations-data-table-with-image/271427
Here's the issue for that elastic/kibana#98257

@alexwizp
Copy link
Contributor

alexwizp commented Jul 8, 2021

Assigned to @VladLasitsa

@chandlerprall chandlerprall changed the title [EuiDataGrid] Enable multiline rows [EuiDataGrid] Auto-fit rows to content Jul 8, 2021
@chandlerprall
Copy link
Contributor

Support for multiline rows added in #4853, I've updated this issue to specifically target fitting height to content.

@cee-chen
Copy link
Contributor

cee-chen commented Sep 21, 2021

Closed by #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants