[Discover] Document explorer rollout by default

[kertal]

Meta issue to track remaining data grid in Discover work.

Required for rollout by default

• [Discover] Allow switching height of rows in data grid #109107 🔧
  • Static height options: [EUI Datagrid] Adds rowHeightOptions property eui#4853
  • Dynamic, auto-fit: [EuiDataGrid] Auto-fit rows to content eui#4958
  • Row height switcher in data grid [EuiDataGrid] Add row height switcher to column eui#5080
  • Increase line height per testing feedback [EuiDataGrid] Add lineHeight configuration to rowHeightsOptions eui#5221
• [Discover] Styling of "Document" when image field formatter is used #106852 🐞
• [Discover] Flyout in Fullscreen mode needs to be full-height #108681 🐞
• [Discover] Make values render in expanded popover formatted (and fix JSON) #118162

QA items

• [Discover] Accessibility audit Data Grid in Discover #109110 🔍
• [Discover] Review Full Screen mode for Data Grid in Discover #109831 🔍

Note: Add any bugs (from below) that are considered blockers.

---

EuiDataGrid component bugs

The following bugs/issues should be resolved in EUI. They are classified by their severity impact on Discover.

High

• [EuiDataGrid][KEYBOARD]: Buttons must be able to receive keyboard focus in table rows eui#5238
• [EuiDataGrid] Keep focus on grid if column gets removed eui#4923

Medium

• [EuiDataGrid] a11y roles not valid (gridcell without row) eui#4474 (a11y failure)
• [EuiDataGrid] Sorting columns after focusing a header cell throws console errors eui#4384
• [EuiDataGrid] Removing a row while a popover is open, opens a popover for another row eui#2625
• [EuiDataGrid] Overflow hidden on cells eui#4959
• [EuiDataGrid] Should not lose focus when scrolling  eui#5047
• [EuiDataGrid & EuiFlyout] Z-Index of flyout is wrong in a full screen eui#3719
• [EuiDataGrid] EuiOverlayMask needs a higher z-index when in fullscreen eui#3469 (another z-index issues)

Medium/Low - need further evaluation

• [EuiDataGrid] regression in displaying Arrays and Objects in expand behavior eui#4957 (maybe in Discover)
• [EuiDataGrid] Scroll cells into view via keyboard eui#4456
• [EuiDataGrid][KEYBOARD]: Can't always view entire last column when layout is zoomed in eui#5481
• Common.tryForTime should return the resolved value #5487

Low

• [EuiDataGrid][COGNITION]: Can we consider separating column header text from the sorting button text? eui#5333
• [EuiDataGrid][AXE-CORE]: Table header text must not be empty eui#5332
• [EuiDataGrid] Need to handle better "no data" scenarios and loading states eui#5026
• [EuiDataGrid] Hovering over a highlightet cell starts button animation again eui#4960
• [EuiDataGrid] Keep focus on grid if column gets removed eui#4923
• [EuiDataGrid] header cell throwing call stack errors eui#4484
• [EuiDataGrid] UX Cleanups eui#4458
• [EuiDataGrid] Header Popover does not re-compute the position in scrollable container eui#4157
• [EuiDataGrid] Sticky headers have trouble with focus and scrolling eui#2990
• [EuiDataGrid][KEYBOARD]: Reordering columns causes a jump when navigating by arrow keys eui#5476
• [EuiDataGrid][KEYBOARD]: Row control button must receive keyboard focus when popover is dismissed eui#5477
• [EuiDataGrid][KEYBOARD]: Update data grid control cells' focus halo to same blue as other cells eui#5479

Kibana Discovery accessibility considerations

These are recommendations and suggestions that have come out of the specialists' audits.

• [CodeEditor][AXE-CORE]: The pink code snippets in our Document JSON flyout must have a contrast ratio of 4.5:1 #121429
• [CodeEditor][COGNITION]: Consider moving tooltip instructions into popovers #121449
• [Discover][KEYBOARD]: Documents selected button should receive keyboard focus when the popover menu is closed #121347
• [Discover][KEYBOARD]: Would we consider adding a Select all / Deselect all control to the available fields for Discover? #121452
• [EuiDataGrid][KEYBOARD]: Could we consider adding a shortcut key or chord to skip to the data grid from anywhere in the page? #121453

---

Further data grid related work

• [Discover] Toast for data grid awareness #98567
• [UnifiedDataTable] Add document/field diffing #93567
• [Discover] Selector for amount of records displayed #94140
• [Discover] Pin records to top of data grid #98431
• [Discover] Lock column when scrolling discover table to the right #12439
• Add a 'Copy to Clipboard' button to Discover for all field types #108857
• [Discover][New table] Improve document selection #99775
• Add a 'copy to clipboard' option to the column menu in the new Table view #103657
• [EuiDataGrid] "Fit to data" mode eui#4627
• Clean up column headers for Sort and Order (rename them to better match functionality)
• user should be able to rename a column in the grid
• user should be able to reset the size of a column
• EuiDataGrid - should allow to hide cell actions in Full screen mode

Removal of legacy grids

• Remove relevant advanced settings (truncate:maxHeight)

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[aarju]

Custom Font size within the EuiDataGrid

[milanage]

Do we consider adding Hide / Unhide column feature? That'll be handy when there are a lot columns.

[VijayDoshi]

@shaunmcgough I've had several people comment on multi-field behavior changes having a big impact on the UX for Discover. Is resolving that part of MVP?

[shaunmcgough]

I think you might be talking about this issue? #96029 We’ve resolved that.

…

-- Shaun Mc Gough Product Manager Based in NYC Search. Observe. Protect

On Aug 12, 2021, at 15:04, VijayDoshi ***@***.***> wrote: @shaunmcgough <https://github.com/shaunmcgough> I've had several people comment on multi-field behavior changes having a big impact on the UX for Discover. Is resolving that part of MVP? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#85965 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPXQL753UEJ7XCZLTAKTSTT4QLNLANCNFSM4U4ONUWQ>.

[ryankeairns]

@timroes @kertal I've added Dave's Full screen flyout height issue to the 'before setting as default' list.

Any thoughts on adding an audit of full screen mode to that list? It seems there were several bugs in that area, in particular.

[timroes]

@ryankeairns Do you mean a general deep audit/testing of the feature or specifically an a11y audit for it? In both cases I think that sounds very good, and should be added to the list :)

[ryankeairns]

Ah, yes, I was referring to a review the full screen feature itself (given the popover and z-index issues, for example).
Also, yes, the a11y audit would cover this feature as well.

[kertal]

@ninoslavmiskovic how should be handle this meta issue, its mission was successful, there are some notes that might be worth to create issues

[kertal]

Closing in favor of: #145993

[kertal]

note that the document explorer was already rolled out, potential follup up improvements that were not implemented were moved to #145993