Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker] Add functionality to extend EuiButton props #4871

Closed
formgeist opened this issue Jun 10, 2021 · 1 comment · Fixed by #4895
Closed

[EuiSuperDatePicker] Add functionality to extend EuiButton props #4871

formgeist opened this issue Jun 10, 2021 · 1 comment · Fixed by #4895
Assignees

Comments

@formgeist
Copy link
Contributor

Summary

As described in elastic/kibana#100881 the implementation of the EuiSuperDatePicker in Kibana will need to update the fill prop in order to remove it so we can use the style in another area of the apps.

Currently, the component does not provide options for extending the EuiButton props which would enable us to change the fill prop value in our implementation.

The result will be that the refresh button can use the default style and we can add the fill style to other primary actions in the UI, like so;

image

@cchaos
Copy link
Contributor

cchaos commented Jun 10, 2021

I think the easiest and scalable solution is to do this is just to have the EuiSuperUpdateButton extend all EuiButton props and then add a updateButtonProps: EuiSuperUpdateButtonProps to the EuiSuperDatePicker component. Of course, we need to be mindful that the consumer cannot override props necessary for the button to behave correctly, so we just need to pay attention to where we spread these props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants