Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperDatePicker] Added prop to control the update button #4895

Merged
merged 4 commits into from
Jun 17, 2021
Merged

[EuiSuperDatePicker] Added prop to control the update button #4895

merged 4 commits into from
Jun 17, 2021

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jun 17, 2021 •
edited
Loading

Summary

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes

  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4895/

cchaos
cchaos approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Kinda wish there was a snapshot output to compare that the EuiButton is rendering with the extra props. But I'll go on faith that these tests pass 😉 . Thanks for tackling this one!

src/components/date_picker/super_date_picker/super_date_picker.tsx Show resolved Hide resolved
src/components/date_picker/super_date_picker/super_date_picker.tsx Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4895/

thompsongl
thompsongl approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM
Happy to discuss better documentation for EuiSuperUpdateButtonProps further

@chandlerprall chandlerprall merged commit 0ed6624 into elastic:master Jun 17, 2021
@chandlerprall chandlerprall deleted the feaature/4871-date-picker-button-props branch June 17, 2021 19:21
@chandlerprall chandlerprall mentioned this pull request Jun 17, 2021
Closed
@thompsongl thompsongl mentioned this pull request Jun 24, 2021
Merged
@andreadelrio andreadelrio mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiSuperDatePicker] Add functionality to extend EuiButton props
4 participants
@chandlerprall @kibanamachine @cchaos @thompsongl