Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Fixed disabled pills and text contrast #4901

Merged
merged 6 commits into from
Jun 23, 2021

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Jun 21, 2021

Summary

This PR fixes the EuiComboBox disabled pills and text color contrast.

This issue was originated by:

-webkit-text-fill-color: $euiFormControlDisabledColor; // Required for Safari

The text and pills were inheriting this -webkit-text-fill-color in webkit browsers. And in no webkit browsers, there were no disabled styles for the pills and texts. They were getting their default colors.

So I added some styles and also added more DisplayToggles with isDisabled states in a few EuiComboBox examples.

combobox disabled@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested a review from cchaos June 21, 2021 15:20
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/

@elizabetdev
Copy link
Contributor Author

Thanks @cchaos.

I fixed the remaining issues based on your review. The PR is ready for another pass.

@elizabetdev elizabetdev requested a review from cchaos June 22, 2021 13:51
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☹️ Looks like there may be a regression now with the placeholder text when disabled. The text color for disabled is not overriding the placeholder text.

Before
Screen Shot 2021-06-22 at 10 14 29 AM

This PR
Screen Shot 2021-06-22 at 10 14 36 AM

CHANGELOG.md Outdated Show resolved Hide resolved
@elizabetdev
Copy link
Contributor Author

The placeholder text color is now fixed 🎉

Screenshot 2021-06-23 at 16 14 09

@elizabetdev elizabetdev requested a review from cchaos June 23, 2021 15:37
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Checked again in Safari and FF.

@elizabetdev elizabetdev merged commit e43e585 into elastic:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants