-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiComboBox] Fixed disabled pills and text contrast #4901
[EuiComboBox] Fixed disabled pills and text contrast #4901
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/ |
Thanks @cchaos. I fixed the remaining issues based on your review. The PR is ready for another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4901/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM! Checked again in Safari and FF.
Summary
This PR fixes the EuiComboBox disabled pills and text color contrast.
This issue was originated by:
eui/src/global_styling/mixins/_form.scss
Line 201 in fb286cb
The text and pills were inheriting this
-webkit-text-fill-color
in webkit browsers. And in no webkit browsers, there were no disabled styles for the pills and texts. They were getting their default colors.So I added some styles and also added more
DisplayToggles
withisDisabled
states in a few EuiComboBox examples.Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes