-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Need to handle better "no data" scenarios and loading states #5026
Comments
Example of the current EuiDataGrid loading new data: Screen.Recording.2021-08-17.at.04.54.PM.mov |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
As we can see from the screenshot (https://codesandbox.io/s/datagrid-header-forked-svk7y?file=/index.js:2560-2571) when no data is available the EuiDataGrid only show the header cells, toolbar and pagination.
This behavior can look like a bug. Users don't know why is the header cells showing, why is the pagination clickable but they can't see any data.
So, we should fix the design to better handle "no data" scenarios.
Design improvement
Bug to fix
className
to EuiDataGrid the Full screen button gets the class. It shouldn't. Fixed with [EuiDataGrid] Fix customclassName
being passed to the full screen button #5050The text was updated successfully, but these errors were encountered: