Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form row help text padding makes spacing inconsistent #792

Closed
cchaos opened this issue May 7, 2018 · 0 comments · Fixed by #811
Closed

Form row help text padding makes spacing inconsistent #792

cchaos opened this issue May 7, 2018 · 0 comments · Fixed by #811
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented May 7, 2018

When building a form with a bunch of EuiFormRows top margins are added to all subsequent siblings creating some nice consistent spacing of rows. However, if one of the form rows has help text, the extra 8px of padding that's added to the bottom of the help text now makes the spacing larger and inconsistent with the rest of the rows.

screen shot 2018-05-07 at 08 19 04 am

screen shot 2018-05-07 at 08 19 33 am

screen shot 2018-05-07 at 08 20 02 am

I'm thinking that we should remove the bottom padding from EuiFormHelpText and add it consistently to all EuiFormRows and maybe subtract that value from the top margin of siblings.

@cchaos cchaos self-assigned this May 7, 2018
cchaos pushed a commit to cchaos/eui that referenced this issue May 7, 2018
- Also fixes elastic#792: Moved bottom padding from help text to form row
cchaos pushed a commit to cchaos/eui that referenced this issue May 7, 2018
- Also fixes elastic#792: Moved bottom padding from help text to form row
@cchaos cchaos mentioned this issue May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant