Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data grid's container gray background transparent #8136

Closed
mariairiartef opened this issue Nov 13, 2024 · 0 comments · Fixed by #8220
Closed

Make data grid's container gray background transparent #8136

mariairiartef opened this issue Nov 13, 2024 · 0 comments · Fixed by #8220

Comments

@mariairiartef
Copy link

mariairiartef commented Nov 13, 2024

Is your feature request related to a problem? Please describe.

In lens, we have noticed that the space below the table is gray. This happens when there are not enough rows to reach the end of the table. As the color is gray, it doesn't match the background.

Image

Additionally, it also looks looks tacky in dashboards as it seems that no other visualization fills empty space with grey.

Image

This table is using the data grid EUI component. You can reproduce the issue here.

We would like to have the possibility of making the table's background transparent to match the background, as @MichaelMarcialis requested here.

Image

Describe the solution you'd like

We have thought about the possibility of exposing a background prop to data grid (whether as a part of gridStyle or somewhere else) to change the color. Another solution would be to remove the background from EUI.

Describe alternatives you've considered

We have opened a pull request that overwrites the background property to make it transparent. We consider this as a temporary solution since this change might cause some problems in the future in case of EUI decides to change data grid's implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants