EuiHeader fixes #1009
Merged
EuiHeader fixes #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 12, 2018 11:44
added 2 commits
July 12, 2018 19:05
chandlerprall
approved these changes
Jul 13, 2018
|
jenkins test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
EuiHeaderresponsive styles and fixes a few other bugs.1. Bug fix: Truncated and responsive breadcrumb styles were not playing nice
If you added both truncation and responsive props to breadcrumbs, the styles didn't hide the correct children via
nth-last-of-typesince the of-type also depends on the dom element.Before
After
2. Style fix: Visual updates to
KeyPadMenuDecreased size of text and bolded labels. Also changed the amount of shifting the icon does between states because the normal state was a bit too close to the label.
Before
After
3. Addition: Added a
HeaderSpacesMenuto showcase that implementationYes, the popover's triangle isn't properly colored, that'll be in a different PR
4. Refactor: Moved
EuiHeaderNotificationto a genericEuiNotificationBadge5. Style fix:
EuiHeaderresponds way better to smaller screen sizesBefore
After
Also fixed the links version
Before
After
6. Bug fix: Fixed the responsive utility (show-for/hide-for) classes for IE
IE doesn't support
display: initial:smh:, so it's set toinlinewhich seems to be whatinitialreturns anyway.TODO: