Add onTableChange callback function to EuiInMemoryTable #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Jul 30, 2018
cjcenizal
reviewed
Jul 31, 2018
| @@ -71,6 +71,7 @@ export const EuiTableHeaderCell = ({ | |||
| className={buttonClasses} | |||
| onClick={onSort} | |||
| aria-label={statefulAriaLabel} | |||
| data-test-subj="tableHeaderButton" | |||
There was a problem hiding this comment.
Maybe tableHeaderSortButton would be a little clearer? If I were to read code with a selector referencing this attribute, I can see myself being unsure what tableHeaderButton is.
Adding this selector will be really helpful for our tests, so big 👍 on adding it. Thanks!
There was a problem hiding this comment.
I like it, change made!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #923 by adding an
onTableChangecallback toEuiInMemoryTable. This callback fires when table sorting or pagination is changed, and is meant to be informational only.@timroes for code review
@snide to make sure the doc change makes sense