Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorate pagination 'next' and 'previous' buttons with data-test-subj #1182

Conversation

justinkambic
Copy link
Contributor

Summary

The purpose of this PR is to add data-test-subj to Pagination's next and previous buttons. I have a number of functional tests expecting a table's pagination to have these values, and when I replaced the existing table with eui components I got stuck. Link to those changes: elastic/kibana#22902

Screens of the props rendered in the docs:

screen shot 2018-09-11 at 10 47 05 am

screen shot 2018-09-11 at 10 47 53 am

I chose these values based on the existing naming used for the numbered buttons, per https://github.com/elastic/eui/blob/master/src/components/pagination/pagination.js#L33

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios

Note: anything unchecked here I did not feel was applicable, please let me know if I need to revisit any items

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

@justinkambic justinkambic merged commit 0697a27 into elastic:master Sep 11, 2018
@justinkambic justinkambic deleted the pagination_decorate-pagination-next-prev-with-datatestsubj branch September 11, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants