Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for string values in search queries #1189

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 13, 2018

closes #1177

Summary

Addresses two string-related issues

  • if a string value began with a number (e.g. 15m) it would be parsed only as the leading number
  • if a non-string value (e.g. 15, true) was passed to a string-type field, it would fail to pass schema validation instead of being coerced to a string

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios

Copy link
Contributor

@bevacqua bevacqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chandlerprall chandlerprall merged commit b02c8e4 into elastic:master Sep 13, 2018
@chandlerprall chandlerprall deleted the bug/1177-search-string-values-with-leading-numbers branch September 13, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar: allow searching for strings starting with numbers, without requiring quotes
2 participants