EuiTableRowCellProps TS defs fixes #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrhodes
reviewed
Nov 15, 2018
| @@ -132,9 +132,16 @@ declare module '@elastic/eui' { | |||
| */ | |||
|
|
|||
| export interface EuiTableRowCellProps { | |||
There was a problem hiding this comment.
Question: why is EuiTableRowCellProps imported at the top of this file, while also exporting it here?
There was a problem hiding this comment.
I have no idea...removed.
jasonrhodes
reviewed
Nov 15, 2018
| align?: HorizontalAlignment; | ||
| hasActions?: boolean; |
There was a problem hiding this comment.
Does colSpan need to go in here too?
There was a problem hiding this comment.
No, but your comment made me realise that I was unioning the wrong props. I've fix that now so that colSpan and friends are correctly merged in.
jasonrhodes
approved these changes
Nov 15, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a bunch of missing props to the TS definition for
EuiTableRowCellProps.