Added iconProps to EuiIconTip
#1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chandlerprall Ready for another review :) |
chandlerprall
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues where the icon inside of an
EuiIconTipwas poorly positioned but I had no way to pass a classname down to the icon as it passed...restto theEuiToolTipcomponent.This adds the
iconPropsprop to pass an object down to theEuiIcon.Also, I ran into an issue in TS where I was trying to pass
EuiToolTipprops fromEuiIconTipvia the...restbut TS complained becuase the def's didn't inherit any of theEuiToolTipdefs. So I think I properly added this. @chandlerprall can you take a look?Checklist
[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components