Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiSuperDatePicker small changes #1464

Merged
merged 9 commits into from
Jan 23, 2019
Merged

EuiSuperDatePicker small changes #1464

merged 9 commits into from
Jan 23, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 23, 2019

Just a couple of quick things that need to be fixed with EuiSuperDatePicker

  1. reset showPrettyDuration on new start or end props
  2. pass refreshInterval to callback when clicking toggle refresh button
  3. round refreshInterval when converted to unit

@nreese nreese requested a review from chandlerprall January 23, 2019 02:51
chandlerprall
chandlerprall approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@nreese nreese merged commit 65e032b into elastic:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @chandlerprall