Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default light theme now comes with an empty light colors file #1479

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Default light theme now comes with an empty light colors file #1479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
167443b
Create empty theme light colors file for swappability
snide Jan 25, 2019
1e4acb1
forgot the file
snide Jan 25, 2019
a6d5aa5
better words
snide Jan 25, 2019
ced8466
extra space
snide Jan 25, 2019
7152d45
Merge branch 'master' into eui/light-theme
snide Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Default light theme now comes with an empty light variables file to make theme switching easier ([#1479](https://github.com/elastic/eui/pull/1479))

**Bug fixes**

- `EuiSuperDatePicker` always trigger `onTimeChange` when time changes and prop `showUpdateButton` is false ([#1477](https://github.com/elastic/eui/pull/1477))
Expand Down
3 changes: 2 additions & 1 deletion src/theme_light.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// This is the default theme, it does not contain any variable overwrites.
// This is the default theme.
@import 'themes/eui/eui_colors_light';

// Global styling
@import 'global_styling/index';
Expand Down
2 changes: 2 additions & 0 deletions src/themes/eui/eui_colors_light.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// This file contains no overwrites because EUI by default is light.
// The file exists in case you ever need to write logic to flip imports in a build process.