Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiSuperDatePicker determine state.isInvalid on props update #1483

Merged
merged 4 commits into from
Jan 28, 2019
Merged

EuiSuperDatePicker determine state.isInvalid on props update #1483

merged 4 commits into from
Jan 28, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 25, 2019

Invalid ranges are not colored as invalid because isInvalid was not getting calculated by getDerivedStateFromProps. Other than that, things are looking really good with embedding EuiSuperDatePicker in Kibana's QueryBar

screen shot 2019-01-25 at 4 11 03 pm

@nreese nreese requested a review from chandlerprall January 25, 2019 23:12
chandlerprall
chandlerprall approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog, otherwise LGTM

@nreese nreese merged commit badc85a into elastic:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @chandlerprall