-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TS types & interfaces from ES exports #1486
Remove TS types & interfaces from ES exports #1486
Conversation
…ported from those statements
f141d12
to
2db60f1
Compare
} | ||
}); | ||
Program: { | ||
enter: function visitProgram(programPath, state) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this enter: {}
block is the same as Program
was previously, just indented another level. The exit
block below is new.
Kibana integration checks out: built & linked EUI still passes tests and runs locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified export
/import
resolution via the same CRA integration mentioned in the issue and description for this PR (tarball dep and @elastic/ui
import target in js).
Did a final check, diffing the contents of |
Summary
Fixes #1376. This extends our typescript->proptypes babel plugin to also remove any types or interfaces from ExportNamedDeclarations e.g.
export { Foo, Bar }
&export { Foo, Bar } from './source';
. Added this functionality to the existing plugin for two reasons: 1. no build tooling in TS or Babel performs this transformation 2. our plugin already tracks variable type information across imports.I tested this change in create-react-app by generating an npm module tarball with
npm pack
and adding the contents of that tarball as a dependency in a new CRA project.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components