-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuperDatePicker] Add onRefresh
handler
#1577
Conversation
src/components/date_picker/super_date_picker/super_date_picker.js
Outdated
Show resolved
Hide resolved
onRefresh
handler (WIP)onRefresh
handler
@nreese How do you suggest we document this feature? |
@cchaos and @chandlerprall any thoughts on how best to document? |
Move the EuiSuperDatePicker to it's own page and split up the examples to address all these edge cases. |
Is this a refactor of the EuiSuperDatePicker docs, or just for the new |
dc76393
to
61e73bf
Compare
src/components/date_picker/super_date_picker/super_date_picker.js
Outdated
Show resolved
Hide resolved
Feedback addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There's just a few outstanding items in the PR checklist to cover, like a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code review
1e528fa
to
5e656ee
Compare
When setting the refresh rate on
EuiSuperDatePicker
it should keep track of the interval, and call theonRefresh
handler whenever the interval fires.This will save consumers the hassle of implementing this logic themselves.
Checklist