Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anchorClassName to ToolTip TS definition #1657

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Add anchorClassName to ToolTip TS definition #1657

merged 5 commits into from
Mar 4, 2019

Conversation

zinckiwi
Copy link
Contributor

@zinckiwi zinckiwi commented Mar 4, 2019

Summary

Add anchorClassName to the TS definition for EuiToolTip.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@zinckiwi zinckiwi requested a review from justinkambic March 4, 2019 01:15
@thompsongl
Copy link
Contributor

Thanks! Just need a changelog entry and this should be ready to go.

thompsongl
thompsongl approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just need to resolve the merge conflict

@zinckiwi
Copy link
Contributor Author

zinckiwi commented Mar 4, 2019

I did...? Does Jenkins need a kick?

@thompsongl
Copy link
Contributor

Looks like another PR with a conflicting changelog entry merged in the meantime

@zinckiwi zinckiwi merged commit 6fff79d into elastic:master Mar 4, 2019
@zinckiwi zinckiwi deleted the tooltip-anchor-ts branch March 4, 2019 19:21
@snide snide mentioned this pull request Mar 7, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@justinkambic justinkambic Awaiting requested review from justinkambic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinckiwi @thompsongl