-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode redux, fix dark mode docs #1691
Conversation
Added some screens from Kibana that I linked locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, had one stupid question. But this looks sooooo goood.
We chatted this out. |
jenkins, test this |
Tweaks dark mode colorscheme.
Summary
Fixes #605
Figured this was one of the few things we could try and get in before RC1.
Updates the dark mode color scheme to get blue hues. I brightened up the colors but have yet to do a full contrast audit other than to see that things generally work. I've tried to steal colors from the upcoming marketing designs as much as I could here so that we match against some of the things they are planning.
I also went ahead and fixed the docs pages to better account for the dark mode palettes. Because of the way they were imported, this required me to duplicate some vars in the
eui_theme_dark.scss
file (like the viz colors or ghost) that were unchanged between themes. I think it's ok to have them there, but would be nice to have a better solution.@cchaos tag you're it. Feel free to commit to this PR directly and adjust whatever you see fit, then pass it to @ryankeairns next.
In Kibana
If you want to try this in Kibana you'll need to run a build of KUI there to generate matching CSS. Assuming we go forward with this, we'll need a PR there to adjust the colors in KUI and bootstrap (neither of which should be too difficult)
Some screens from there
Checklist