Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] EuiBottomBar refers to the end of document. #1727

Merged
merged 4 commits into from
Mar 15, 2019
Merged

[Accessibility] EuiBottomBar refers to the end of document. #1727

merged 4 commits into from
Mar 15, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Mar 13, 2019

Summary

FIxes #1696. EuiBottomBar uses non-visual language.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall
Copy link
Contributor

It looks like your PR contains a commit (1b2df71) that already exists on master. Can you rebase your branch and force push?

@theodesp
Copy link
Contributor Author

@chandlerprall done. Thanx

@thompsongl
Copy link
Contributor

jenkins test this

CHANGELOG.md Outdated Show resolved Hide resolved
@theodesp
Copy link
Contributor Author

Added the missing "the"

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last bit with the CL

CHANGELOG.md Outdated Show resolved Hide resolved
@theodesp
Copy link
Contributor Author

theodesp commented Mar 15, 2019

@snide for some reason Github comments are behaving wierd and I cannot reply or resolve the conversation. I've moved the entry to master

@snide snide merged commit 90240a0 into elastic:master Mar 15, 2019
@snide
Copy link
Contributor

snide commented Mar 15, 2019

@theodesp Congrats on your first merge to EUI. We appreciate the help! Your change will go out in the next release (usually we release one or two times each week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants