Prevent an empty badge color from blowing things up #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevacqua
reviewed
Mar 19, 2019
src/services/color/hex_to_rgb.ts
Outdated
| if (result) { | ||
| const [, r, g, b] = result; | ||
| return [parseInt(r, 16), parseInt(g, 16), parseInt(b, 16)]; | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| } else { | |
| } |
😅
bevacqua
approved these changes
Mar 19, 2019
chandlerprall
force-pushed
the
eui-badge-blowup
branch
from
4264ef3 to
579648f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes
EuiBadgeresilient to an empty string passed intocolorhexToRgbto prevent destructuring anullEuiBadgeto properly warn whencoloris emptyChecklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components