Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pager service and EuiTablePagination component #178

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Add Pager service and EuiTablePagination component #178

merged 4 commits into from
Dec 4, 2017

Conversation

cjcenizal
Copy link
Contributor

No description provided.

@cjcenizal cjcenizal requested review from bevacqua and snide December 1, 2017 21:52
@cjcenizal
Copy link
Contributor Author

CC @snide @bevacqua I added a component that encapsulates some of the pagination sub-components, and a matching service for encapsulating pagination logic. This will make it easier for people to implement table pagination.

@bevacqua
Copy link
Contributor

bevacqua commented Dec 1, 2017

Screenshots? 😅

@cjcenizal
Copy link
Contributor Author

image

It's the same thing we have now from a UI standpoint, but now encapsulated in a single component.

@cjcenizal cjcenizal merged commit 55fc0ea into elastic:master Dec 4, 2017
@cjcenizal cjcenizal deleted the pager-service branch December 4, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevacqua bevacqua Awaiting requested review from bevacqua

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @bevacqua