Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiTitle Converted to TS #1810

Merged
merged 7 commits into from
Apr 11, 2019
Merged

EuiTitle Converted to TS #1810

merged 7 commits into from
Apr 11, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Apr 9, 2019 •
edited
Loading

Summary

Converted EuiTitle to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@theodesp
Copy link
Contributor Author

@cchaos PR updated. Ta.

chandlerprall
chandlerprall approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and snapshot changes LGTM

@chandlerprall chandlerprall requested a review from cchaos April 10, 2019 15:02
cchaos
cchaos suggested changes Apr 10, 2019
View reviewed changes
src/components/title/title.tsx Outdated Show resolved Hide resolved
cchaos
cchaos suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more thing I had overlooked.

src/components/title/index.ts Outdated Show resolved Hide resolved
chandlerprall
chandlerprall suggested changes Apr 11, 2019
View reviewed changes
src/components/title/title.tsx Outdated Show resolved Hide resolved
@theodesp
Copy link
Contributor Author

theodesp commented Apr 11, 2019 •
edited
Loading

PR updated, but let me know if you don't want to export the EuiTitleSize in the index

chandlerprall
chandlerprall approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@chandlerprall chandlerprall requested a review from cchaos April 11, 2019 17:04
@theodesp
Copy link
Contributor Author

@chandlerprall I've resolved the conflicts

@chandlerprall chandlerprall merged commit ce003eb into elastic:master Apr 11, 2019
@theodesp theodesp deleted the task/Title-to-TS branch April 18, 2019 19:40
@chandlerprall chandlerprall mentioned this pull request Apr 22, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @chandlerprall @cchaos