Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matching_options converted to TS+tests #1828

Merged
merged 5 commits into from
Apr 17, 2019
Merged

matching_options converted to TS+tests #1828

merged 5 commits into from
Apr 17, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Apr 12, 2019 •
edited
Loading

Summary

converted matching_options to TS and added tests

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

thompsongl
thompsongl suggested changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

Looks like the old .js file needs to be removed

@theodesp theodesp force-pushed the task/matching_options-to-TS branch from 8343f4a to 06df874 Compare April 15, 2019 12:53
@theodesp
Copy link
Contributor Author

@thompsongl PR updated

@theodesp
Copy link
Contributor Author

@thompsongl thanx. I didn't realise there was an existing type for it. I will update the PR soon.

@theodesp
Copy link
Contributor Author

@thompsongl PR updated

@theodesp theodesp force-pushed the task/matching_options-to-TS branch from a596d18 to e99c321 Compare April 17, 2019 13:20
@theodesp
Copy link
Contributor Author

@thompsongl I have added a Changelog Entry

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

theodesp commented Apr 17, 2019 •
edited
Loading

@thompsongl I have resolved the conflicts

@thompsongl
Copy link
Contributor

jenkins test this

@thompsongl thompsongl merged commit 6579cb4 into elastic:master Apr 17, 2019
@theodesp theodesp deleted the task/matching_options-to-TS branch April 18, 2019 19:39
This was referenced Apr 22, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theodesp @elasticmachine @thompsongl