Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snippets to accordion docs #1831

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Add snippets to accordion docs #1831

merged 3 commits into from
Apr 15, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Apr 12, 2019 •
edited
Loading

Summary

Tending garden 🥕, just adding some snippets to the EuiAccordion docs.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns force-pushed the rk/accordion-snippets branch from b7d6cd8 to 74060dc Compare April 12, 2019 21:58
@ryankeairns ryankeairns marked this pull request as ready for review April 12, 2019 21:59
@ryankeairns ryankeairns changed the title Adds snippets to accordion docs Add snippets to accordion docs Apr 12, 2019
@ryankeairns ryankeairns added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Apr 12, 2019
thompsongl
thompsongl approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱

@chandlerprall
Copy link
Contributor

I don't think this should have a changelog entry as it doesn't add/change any functionality

@ryankeairns ryankeairns force-pushed the rk/accordion-snippets branch from 74060dc to 18453eb Compare April 15, 2019 14:46
@ryankeairns
Copy link
Contributor Author

Changed this PR to remove the CHANGELOG changes.

@chandlerprall
Copy link
Contributor

@ryankeairns thanks!

cchaos
cchaos suggested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions so we consider what our future patterns should be for creating these snippets.

src-docs/src/views/accordion/accordion_example.js Outdated Show resolved Hide resolved
src-docs/src/views/accordion/accordion_example.js Outdated Show resolved Hide resolved
@ryankeairns ryankeairns requested a review from cchaos April 15, 2019 16:08
cchaos
cchaos approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

I had one word suggestion, and found an old typo, can you fix this?

Screen Shot 2019-04-15 at 12 48 48 PM

src-docs/src/views/accordion/accordion_example.js Outdated Show resolved Hide resolved
@ryankeairns ryankeairns merged commit 768d4bf into elastic:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@thompsongl thompsongl thompsongl approved these changes

@snide snide Awaiting requested review from snide

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryankeairns @chandlerprall @cchaos @thompsongl