Fix EuiNavDrawer scroll overflow issue on Firefrox #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
force-pushed
the
rk/nav-drawer-scroll-ff
branch
from
418d144 to
fb4839a
Compare
cchaos
approved these changes
Apr 15, 2019
cchaos
reviewed
Apr 15, 2019
ryankeairns
force-pushed
the
rk/nav-drawer-scroll-ff
branch
from
fb4839a to
5918a65
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue that was opened in the Kibana repo: elastic/kibana#35083
It seems this comes down to difference of interpretation for the overflow spec. The Mozilla team seems to have taken a slightly different approach (than other browsers) with regards to where they apply bottom padding when there is overflow: https://bugzilla.mozilla.org/show_bug.cgi?id=748518
There were several kludge solution, but simply changing this from
padding-bottomtomargin-bottomdid the trick.Tested EUI docs and Kibana on FF, Chrome, and IE.
Firefox recording
Checklist
This was checked in dark modeAny props added have proper autodocsDocumentation examples were addedJest tests were updated or added to match the most common scenariosThis required updates to Framer X components