Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a namespace and module token. #1839

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Adding a namespace and module token. #1839

merged 3 commits into from
Apr 18, 2019

Conversation

daveyholler
Copy link
Contributor

Summary

Added 2 additional specific token icons: tokenNamespace and tokenModule

Checklist

  • This was checked in mobile
  • This was checked in IE11 fixes are needed for all tokens, to come in a follow-up PR
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@daveyholler daveyholler requested review from cchaos and snide April 16, 2019 00:59
@daveyholler daveyholler force-pushed the namespace_token_icons branch from d572023 to 93e4160 Compare April 16, 2019 17:11
@cchaos
Copy link
Contributor

cchaos commented Apr 17, 2019

Is tokenModule's icon supposed to be full black?
Screen Shot 2019-04-17 at 09 55 52 AM

cchaos
cchaos approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the screenshot in the summary was out of date. Checked locally, LGTM
Screen Shot 2019-04-17 at 09 57 30 AM

@daveyholler daveyholler force-pushed the namespace_token_icons branch from 93e4160 to c901155 Compare April 18, 2019 16:33
@daveyholler daveyholler merged commit 1a51009 into elastic:master Apr 18, 2019
This was referenced Apr 22, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveyholler @cchaos