Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use span for loaders and set width to kibana loader #1845

Merged
merged 4 commits into from
Apr 17, 2019
+292 −275
Merged

Use span for loaders and set width to kibana loader #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
838c630
use span for loaders and set width to kibana loader
snide Apr 16, 2019
6f24e1e
cl
snide Apr 16, 2019
b12443b
typo
snide Apr 17, 2019
0f0cc03
feedback
snide Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ No public interface changes since `10.0.1`.

- Convert `EuiText`, `EuiTextColor` and `EuiTextAlign` to TS ([#1791](https://github.com/elastic/eui/pull/1791))
- Updated `IconColor` type to better distinguish between accepted types ([#1842](https://github.com/elastic/eui/pull/1842))
- Changed `EuiLoadingKibana`, `EuiLoadingSpinner`, `EuiLoadingChart` and `EuiLoadingContent` components to use spans instead of divs ([#1845](https://github.com/elastic/eui/pull/1845))

**Bug fixes**

- Changed `EuiLoadingKibana` so it could better nest within `EuiFlexItem` ([#1845](https://github.com/elastic/eui/pull/1845))

## [`10.0.0`](https://github.com/elastic/eui/tree/v10.0.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/button/__snapshots__/button.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ exports[`EuiButton props isLoading is rendered 1`] = `
<span
class="euiButton__content"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButton__spinner"
/>
<span
Expand Down
2 changes: 1 addition & 1 deletion src/components/facet/__snapshots__/facet_button.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ exports[`EuiFacetButton props isLoading is rendered 1`] = `
>
Content
</span>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiFacetButton__spinner"
/>
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/form_control_layout/__snapshots__/form_control_layout.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ exports[`EuiFormControlLayout props isLoading is rendered 1`] = `
<div
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/super_select/__snapshots__/super_select_control.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ Array [
<div
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<div
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
/>
<span
Expand Down
60 changes: 30 additions & 30 deletions src/components/loading/__snapshots__/loading_chart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,98 +1,98 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`EuiLoadingChart is rendered 1`] = `
<div
<span
aria-label="aria-label"
class="euiLoadingChart testClass1 testClass2 euiLoadingChart--medium"
data-test-subj="test subject string"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart mono is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--mono euiLoadingChart--medium"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size l is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--large"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size m is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--medium"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;

exports[`EuiLoadingChart size xl is rendered 1`] = `
<div
<span
class="euiLoadingChart euiLoadingChart--xLarge"
>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
<div
<span
class="euiLoadingChart__bar"
/>
</div>
</span>
`;
Loading