Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiOverlayMask converted to TS #1858

Merged
merged 4 commits into from
Apr 24, 2019
Merged

EuiOverlayMask converted to TS #1858

merged 4 commits into from
Apr 24, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Apr 19, 2019 •
edited
Loading

Summary

Converted EuiOverlayMask to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@theodesp theodesp force-pushed the task/EuiOverlayMask-to-TS branch from 8dc1218 to 68396df Compare April 19, 2019 09:45
@theodesp theodesp force-pushed the task/EuiOverlayMask-to-TS branch from 68396df to 965765f Compare April 23, 2019 10:48
@theodesp
Copy link
Contributor Author

@chandlerprall I have updated my PR. Ta

thompsongl
thompsongl approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

@thompsongl conflicts resolved

@thompsongl
Copy link
Contributor

jenkins test this

@thompsongl thompsongl merged commit 2d0ac3b into elastic:master Apr 24, 2019
@chandlerprall chandlerprall mentioned this pull request May 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall left review comments

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theodesp @elasticmachine @thompsongl @chandlerprall @snide