Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiStepNumber converted to TS #1893

Merged
merged 3 commits into from
May 21, 2019
Merged

EuiStepNumber converted to TS #1893

merged 3 commits into from
May 21, 2019

Conversation

theodesp
Copy link
Contributor

Summary

Converted EuiStepNumber to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

thompsongl
thompsongl suggested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, again, for the conversion

src/components/icon/icon.tsx Outdated Show resolved Hide resolved
src/components/steps/step_number.tsx Show resolved Hide resolved
@theodesp theodesp force-pushed the task/EuiStepNumber-to-TS branch from cc37b6d to 61c69bc Compare May 13, 2019 10:20
@theodesp theodesp force-pushed the task/EuiStepNumber-to-TS branch from 61c69bc to e182a39 Compare May 13, 2019 10:21
@theodesp
Copy link
Contributor Author

@thompsongl PR updated

@thompsongl
Copy link
Contributor

jenkins test this

@theodesp
Copy link
Contributor Author

@thompsongl Conflicts resolved

@thompsongl
Copy link
Contributor

Thanks, @theodesp

@thompsongl thompsongl merged commit d062223 into elastic:master May 21, 2019
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theodesp @elasticmachine @thompsongl