Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative_options converted to TS #1921

Merged
merged 4 commits into from
May 9, 2019
Merged

relative_options converted to TS #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
534bc64
`relative_options` converted to TS
May 7, 2019
909de8d
`relactive_options` Code Review
May 8, 2019
84b0ba4
`relactive_options` Changelog
May 8, 2019
0cc8655
Merge branch 'master' into task/relative_options-to-TS
theodesp May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Converted `relative_options` to TS ([#1921](https://github.com/elastic/eui/pull/1921))

**Bug fixes**

- Removed unused prop enum of `l` in `EuiButton` ([#1936](https://github.com/elastic/eui/pull/1936))
Expand Down
18 changes: 18 additions & 0 deletions src/components/date_picker/super_date_picker/relative_options.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { relativeUnitsFromLargestToSmallest } from './relative_options';

describe('relativeUnitsFromLargestToSmallest', () => {
test('relativeUnitsFromLargestToSmallest length', () => {
expect(relativeUnitsFromLargestToSmallest.length).toBe(7);
});
test('relativeUnitsFromLargestToSmallest order', () => {
expect(relativeUnitsFromLargestToSmallest).toEqual([
'y',
'M',
'w',
'd',
'h',
'm',
's',
]);
});
});
1 change: 0 additions & 1 deletion ...ker/super_date_picker/relative_options.js → ...ker/super_date_picker/relative_options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

export const relativeOptions = [
{ text: 'Seconds ago', value: 's' },
{ text: 'Minutes ago', value: 'm' },
Expand Down