Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Steps component #201

Closed
wants to merge 1 commit into from
Closed

add Steps component #201

wants to merge 1 commit into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 11, 2017

Needs some CSS work to use variable instead of hard coded colors and sizes but otherwise is complete

screen shot 2017-12-11 at 2 03 40 pm

@nreese nreese requested review from snide and cjcenizal December 11, 2017 21:13
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS will need to be rewritten for this to use our usual sass variable stuff, and I'll also likely change the defined classes (like title and text) you're defining to just use existing components (like EuiTitle and EuiText).

Functionality seems ok and @cchaos or I can make those changes in a subsequent PR.

@cchaos
Copy link
Contributor

cchaos commented Dec 11, 2017

I can handle the CSS updates.

@nreese
Copy link
Contributor Author

nreese commented Dec 11, 2017

@snide @cjcenizal Should the content of each step be more riggid? Like pre-text, commands, post-text? Or, should it just be any generic node?

@snide
Copy link
Contributor

snide commented Dec 11, 2017

@nreese I think you want generic nodes. It's more flexible. The docs can always handle use cases for what to stuff in there (which is what I'd recommend in your examples... like showing a full instruction with code / text mixed in...etc).

@cjcenizal
Copy link
Contributor

cjcenizal commented Dec 11, 2017

Should the content of each step be more rigid?

I think it's perfect the way it is now. I think more rigid components for various formats of content may belong closer to where EuiSteps is consumed. If we want to provide guidance on how this format should look, then maybe we can document it in a sandbox or in a new "Patterns" section.

@cchaos
Copy link
Contributor

cchaos commented Dec 11, 2017

@snide Do we want to be able to customize the step coloring?

@snide
Copy link
Contributor

snide commented Dec 11, 2017

@cchaos Probably. I'm thinking more in a sense of a trackable step (ex: primary are completed steps, gray for incomplete ones...etc). We'd want to set a default though (i think the blue primary is fine for this for now).

@nreese
Copy link
Contributor Author

nreese commented Dec 12, 2017

Created new PR, #202, that merges against feature branch instead of merging into master

@nreese nreese closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants