Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly #205

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly #205

merged 2 commits into from
Dec 14, 2017

Conversation

ycombinator
Copy link
Contributor

This PR:

  • Adds a new euiFlexGroup--justifyContentSpaceEvenly CSS class
  • Adds corresponding spaceEvenly option to justifyContent prop on the EuiFlexGroup component
  • Updates the corresponding Jest snapshot to cover the new option
  • Adds corresponding documentation
  • Adds CHANGELOG item

@ycombinator ycombinator mentioned this pull request Dec 14, 2017
Merged
@ycombinator ycombinator changed the title [EuiFlexGroup] Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Dec 14, 2017
@ycombinator ycombinator changed the title Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly Dec 14, 2017
cjcenizal
cjcenizal approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 LGTM! One minor comment. Thanks for this!

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `0.0.5`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete this line?

@ycombinator ycombinator merged commit f8d7882 into elastic:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@bevacqua bevacqua Awaiting requested review from bevacqua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycombinator @cjcenizal