Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magnifyWithMinus and magnifyWithPlus (aka zoom) icons #2056

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jun 18, 2019

Fixes #2045

Summary

Adds magnifyWithMinus (zoom out) and magnifyWithPlus (zoom in) icons with genericized/literal names.

Light mode

Screenshot 2019-06-19 08 36 45

Dark mode

Screenshot 2019-06-19 08 37 00

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns marked this pull request as ready for review June 18, 2019 21:35
@ryankeairns ryankeairns requested a review from andreadelrio June 18, 2019 21:35
@cchaos
Copy link
Contributor

cchaos commented Jun 18, 2019

@ryankeairns Can you commit the icons to Abstract as well so I can view the pixel grid?

@ryankeairns
Copy link
Contributor Author

ryankeairns commented Jun 18, 2019

@cchaos done! They're based on the existing Search icon, then I centered the minus and plus leaving a two pixel gap. This means they're on subpixels, but it keeps them centered and with a 1 pixel weight.

@ryankeairns
Copy link
Contributor Author

I'll post up a version with a smaller magnifying glass where the plus/minus is not on subpixels.

@ryankeairns
Copy link
Contributor Author

ryankeairns commented Jun 18, 2019

@cchaos If we're ok with shrinking the magnifying glass by a pixel, then we end up with this. By 'ok' I mean, we should probably then do the same to the existing search icon (though we don't have to).

at 16px

Screenshot 2019-06-18 17 09 47

zoomed in for detail

Screenshot 2019-06-18 17 08 41

@cchaos
Copy link
Contributor

cchaos commented Jun 18, 2019

Yeah, I'd opt for making sure they're aligned to the pixel grid. I think ensuring readability (less fuzziness) for those without retina displays is more important than trying to match sizing with other semi-related icons. I can't imagine when the normal magnify would be used in conjunction with these. If we do see that case, we can revisit.

@cchaos
Copy link
Contributor

cchaos commented Jun 18, 2019

I did notice there's a hard-corner on the smaller magnify where there was a round corner. Perhaps that can get rounded as well?

@ryankeairns
Copy link
Contributor Author

ryankeairns commented Jun 19, 2019

Updated description with new screenshots; rounded off that point.

Here are the pixel-level details from Sketch:

Screenshot 2019-06-19 08 41 15

Screenshot 2019-06-19 08 41 31

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@ryankeairns ryankeairns merged commit b0ac716 into elastic:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zoom icon
2 participants