-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting to fix with EuiFlyout maxWidth #2125
Conversation
The only thing I can think of is to get more JS involved :ducks: eui/src/components/flyout/flyout.js Lines 46 to 47 in ca58f3d
I'm not convinced this is a good idea yet |
I think, generally, the current functionality is better (minWidth wining); A flyout's content should be important enough to demand the greater screen real estate. That said, I'm sure there are valid use cases for restricting the width smaller than the minWidth, but I feel that should be an opt-in case - perhaps we provide a prop that sets |
@cchaos I'm OK with minwidth winning as well. It might be unexpected, but it's generally going to be "more right most of the time". If we felt extremely strong about it, we could just add a |
Ok, I updated the summary of the PR to align with the actual changes in this PR. (Moved the original summary to an issue for tracking). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code & docs changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small suggestion for your 404 change.
Also fixed up 404 page
..to accomodate forms. Also added docs example for this forms width trick.
Co-Authored-By: dave.snider@gmail.com <dave.snider@gmail.com>
Fixes #2134 (kind of)
Really all I did was change the docs example to a) not be wrong, b) showcase all the permutations to show what works and what doesn't.
But I also:
Checklist
[ ] This was checked in dark mode[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components