Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react datepicker deps #2160

Merged

Conversation

chandlerprall
Copy link
Contributor

Summary

Addresses some identified build/dev tooling vulnerabilities in the forked react-datepicker package.

This also updated enzyme packages & webpack configuration to get the yarn test command passing.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added
- [ ] A changelog entry exists and is marked appropriately

  • This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@chandlerprall chandlerprall requested a review from thompsongl July 23, 2019 17:48
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Tested locally that react-datepicker docs still build and EUI examples work as expected.

@chandlerprall chandlerprall merged commit 7ada6c0 into elastic:master Jul 23, 2019
@chandlerprall chandlerprall deleted the upgrade-react-datepicker-deps branch July 23, 2019 18:33
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
* working & passing react-datepicker tests

* Upgrade react-datepicker dependencies to patch security flaws in some build & dev tooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants