[EuiDataGrid] Base layer Sass #2171

snide · 2019-07-26T07:59:46Z

Summary

This is a really simple PR that just adds some basic Sass. It's just meant to make things mostly usable and isn't a deep dive into how we should necessarily do things.

I'm going to attempt to make these PRs frequent and small so that they are reviewable. All that said, early on a lot of this stuff is knowingly temporary as we build up the component. For example, I'm not concentrating too much on style yet since that will have it's own configuration layer.

TODO

Fix IE11 issue with grid overflow

Uses `inline-flex` + a wrapping max width container to allow for overflows when it gets too big.

Sets up very basic truncation and tabular numbers

This will likely change once node type content is passed in, but for now it works. We'll likely want to apply auto styling to certain data types so this is what too heavy handed.

Reworked hit/drag zones for column resizing

Made this stuff a lot easier to handle with a fat, invisible hitzone.
Turned off user-select on the text in the header only (which it think should be ok long term) because it gets in the way with dragging.

Works in mobile / dark mode better

Will need to figure out how to do the drag bits. The don't work because of the reliance on hover. Later PR.

Works in IE11

Checklist

Checked in dark mode
Checked in mobile
Checked in IE11 and Firefox
Props have proper autodocs
Added documentation examples
Added or updated jest tests
~~Checked for breaking changes and labeled appropriately~~
~~Checked for accessibility including keyboard-only and screenreader modes~~
~~A changelog entry exists and is marked appropriately~~

snide · 2019-07-26T14:37:32Z

jenkins test this

chandlerprall · 2019-07-26T15:26:21Z

src/components/datagrid/data_grid.tsx

@@ -63,7 +63,7 @@ export class EuiDataGrid extends Component<EuiDataGridProps, EuiDataGridState> {
    const { columns, rowCount, renderCellValue, ...rest } = this.props;

    return (
-      <div {...rest}>
+      <div {...rest} className="euiDataGrid">


This overrides any className in rest, instead these should be merged together:

include className when destructuring from this.props

replace this prop assignment with className={classnames(className, 'euiDataGrid')}

This should revert the snapshot change in data_grid.test.tsx.snap

chandlerprall · 2019-07-26T15:27:56Z

Assuming we want to get this working in IE before merging?

snide · 2019-07-26T15:41:12Z

@chandlerprall addressed feedback and this now works in ie11 (screen in desc)

chandlerprall

LGTM

cchaos

🎉 🎉

src/components/datagrid/_data_grid.scss

cchaos · 2019-07-26T15:26:18Z

src/components/datagrid/_data_grid_column_resizer.scss

  height: 100%;
-  width: 3px;
-  background-color: $euiColorDarkestShade;
+  width: $euiSize;


src/components/datagrid/_data_grid_column_resizer.scss

src/components/datagrid/_data_grid_header_row.scss

ryankeairns · 2019-07-26T21:42:14Z

This is so rad!

* initial datagrid * protect against re-rendering content on column width change * Added unit initial tests for EuiDataGrid * [EuiDataGrid] Base layer Sass (#2171) * Initial css fixes * works in IE, addresses feedback * remove user select * Adds basic aria roles and grid navigation (#2187) * Adds basic aria roles and grid navigation Co-Authored-By: Chandler Prall <chandler.prall@gmail.com> * [Data Grid] Grid style options (#2176) Adds basic styling to the data grid. * Add pagination to EuiDataGrid (#2188) * Added pagination to to EuiDataGrid * Move EuiDataGrid row rendering to a sub-component to clean up state management * EuiDataGrid pagination unit tests * fix data grid pagination * revert colors * EuiDataGrid column visibility & ordering (#2207) * Show/hide and re-order datagrid columns * Column visability & ordering tests * column styling * column sizing and bars * blergh * tests * feedback * Fix linting * Adds more complex focus control for DataGrid (#2222) * [Data Grid] - Styling built into data grid, full screen mode (#2230) Styling built into data grid, full screen mode * EuiDataGrid add column sorting (#2278) * API interface for providing column sort order, callback to allow external data sorting * EuiDataGrid renders content into memory, sorts on it * Added tests for EuiDataGrid sorting * Added aria-sort value to a singly-sorted column header * small cleanup * add tests back in, though they are still broken * Clean up some keyboard navigation issues * Fix column sorting & update snapshots * EuiDataGrid hooks cleanup (#2331) * Refactored EuiDataGrid's hooks * Fix datagrid to react to gridStyle changes * [EuiDataGrid] Automatic column schema detection (#2351) * Automatically detect data schema for in-memory datagrid * Merge in described schema for field formatting * Better column type detection * Tests for euidatagrid schema / column type * refactor datagrid schema code, add datetime type detection * some comments * Allow extra type detectors for EuiDataGrid * cleanup of docs and type formatting * Fix datagrid unit test * Update currency detector * Allow EuiDataGrid's inMemory prop to be {true} * Added ability to provide extra props for the containing cell div * Added test for cell props * [EuiDataGrid] InMemory Performance (#2374) * Automatically detect data schema for in-memory datagrid * Merge in described schema for field formatting * Better column type detection * Tests for euidatagrid schema / column type * refactor datagrid schema code, add datetime type detection * some comments * Allow extra type detectors for EuiDataGrid * cleanup of docs and type formatting * Fix datagrid unit test * Update currency detector * Allow EuiDataGrid's inMemory prop to be {true} * Added ability to provide extra props for the containing cell div * Added test for cell props * Performance cleanups * Clean up datagrid doc's inMemory selection * Merged in feature branch * EuiDataGrid in-memory options * Performance refactor for in-memory values * added a comment * Fix sorting on in-memory and schema datagrid docs * [EuiDataGrid] Feature/euidatagrid menu ux (#2392) Moved the sorting mechanism to the top toolbar. * Export useRenderToText to top-level package (#2412) * [DATA GRID] Expand cells (#2418) Data grid cells now can expand and can render individually based upon their schema. * [EuiDataGrid] use schema information when sorting (#2419) * cell expansion working mostly * fix double import * add search to field selector * euitext * cell epansion is now optional through a config * keydown event for cells * remove tabbables * Clean up some code & tests * Remove unused line of code * Center popover against cell * Update euidatagridcell popover placement, trigger, dom structure, and auto focusing * Restore focus to grid cell when popover was in response to mouse click * Allow grid column selection to be searchable * Refactor expansion popover formatting, allow custom ones * schema-based sort comparators * reverse boolean sort to be true-false * adds json schema sorting, fixes issue with popover * Weaken the currency type detector when values have a period in their first few characters, and fix test * Move column order and visibility to be managed externally (#2422) * fix tests * [EuiDataGrid] Custom column headers (#2421) * Allow custom ReactNode for column header display * Allow navigation into grid headers if any are interactive * Properly wrap cell focus and use [enter], [f2] to interact * Corrected header cell focus-state on blurring, [escape]. and single interactives * Corrected header cell focus-state on blurring, [escape]. and single interactives * When datagrid header is interactive, default its tabstop to the first header cell * EuiDataGridHeaderCell warns about multiple interactive elements * fix focus, example and screenreader stuffs, looks like tests pass * simplifying screen reader read out * [DATA GRID] EuiGridToolBar toolbar is now configurable through props (#2443) * EuiGridToolBar toolbar is now configurable through props * better tests * small test typp * Update src/components/datagrid/data_grid_types.ts Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * feedback * [EuiDataGrid] Docs and autodocs (#2449) * Render out EuiDataGrid proptypes * Add pagination props to docs * Fill out all datagrid autodoc sections * remove debugger statement * Update src/components/datagrid/data_grid_types.ts Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * words * docs start * datatype renamed to schema, update docs * docs, fix typo for fullscreen buton * core concepts * better in memory explanation * custom schema example * provide a nice, documented snippet * typos * don't show pagination when only one page * clean up styling, better docs for formatters * more docs cleanup * IE fix * IE fix again * small cleanup of docs * describe how to disable expansion popovers * dark mode tweaks * Fix custom datatype sorting * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * Update src-docs/src/views/datagrid/datagrid_example.js Co-Authored-By: Michail Yasonik <michail@yasonik.com> * PR feedback * typo * feedback to break up docs * better cross linking and summary * fix custom schema display * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_schema_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Update src-docs/src/views/datagrid/datagrid_memory_example.js Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com> * Updated some datagrid docs * main dg example page feedback * Eui prefix all the things to be consistant. Adjust the data grid docs to match * rewrite intro based on feedback * more tweaking of words * rename toolbarDisplay->toolbarVisibility * in memory docs reworked to four examples * clean up core example * data grid styling snippets * fix prop list * Minor grammar edits * Added isDetails prop to renderCellValue, reducing the use case for expansionFormatters. Speaking of those, expansionFormatter(s) has been renamed to popoverContent(s) and now recieve the rendered cell div in addition to the renderCellValue ReactElement * fix docs renaming, fix css * last docs edit seems fitting * somewhat decent attempt at putting classnames on schemas * Revert "somewhat decent attempt at putting classnames on schemas" This reverts commit 26542d7. * changelog

Initial css fixes

d87ea6e

snide requested a review from chandlerprall July 26, 2019 08:00

chandlerprall suggested changes Jul 26, 2019

View reviewed changes

works in IE, addresses feedback

6cb11d1

chandlerprall approved these changes Jul 26, 2019

View reviewed changes

cchaos reviewed Jul 26, 2019

View reviewed changes

remove user select

e0069e5

snide merged commit b09923e into elastic:feature/euidatagrid Jul 26, 2019

snide deleted the grid/design_1 branch July 26, 2019 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EuiDataGrid] Base layer Sass #2171

[EuiDataGrid] Base layer Sass #2171

snide commented Jul 26, 2019 •

edited by chandlerprall

Loading

snide commented Jul 26, 2019

chandlerprall Jul 26, 2019

chandlerprall commented Jul 26, 2019

snide commented Jul 26, 2019

chandlerprall left a comment

cchaos left a comment

cchaos Jul 26, 2019

ryankeairns commented Jul 26, 2019

[EuiDataGrid] Base layer Sass #2171

[EuiDataGrid] Base layer Sass #2171

Conversation

snide commented Jul 26, 2019 • edited by chandlerprall Loading

Summary

TODO

Uses inline-flex + a wrapping max width container to allow for overflows when it gets too big.

Sets up very basic truncation and tabular numbers

Reworked hit/drag zones for column resizing

Works in mobile / dark mode better

Works in IE11

Checklist

snide commented Jul 26, 2019

chandlerprall Jul 26, 2019

Choose a reason for hiding this comment

chandlerprall commented Jul 26, 2019

snide commented Jul 26, 2019

chandlerprall left a comment

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

cchaos Jul 26, 2019

Choose a reason for hiding this comment

ryankeairns commented Jul 26, 2019

snide commented Jul 26, 2019 •

edited by chandlerprall

Loading

Uses `inline-flex` + a wrapping max width container to allow for overflows when it gets too big.