Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export used react-beautiful-dnd interfaces through EUI #2173

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jul 26, 2019

Summary

Closes #2172, exports any interfaces EUI's drag&drop components imports from react-beautiful-dnd.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@chandlerprall chandlerprall requested a review from thompsongl July 26, 2019 16:20
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice

@chandlerprall chandlerprall merged commit 278a16d into elastic:master Jul 26, 2019
@chandlerprall chandlerprall deleted the feature/export-react-dnd-types branch July 26, 2019 17:01
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
* Export used react-beautiful-dnd interfaces through EUI

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the drag'n'drop types
2 participants