Convert EuiSwitch to TS
#2243
Merged
Convert EuiSwitch to TS
#2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
commented
Aug 21, 2019
chandlerprall
suggested changes
Aug 21, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Aug 23, 2019
This reverts commit 39dbcf6.
1 task
thompsongl
added a commit
that referenced
this pull request
Aug 23, 2019
thompsongl
added a commit
that referenced
this pull request
Aug 23, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Revert "Convert `EuiSwitch` to TS (elastic#2243)" This reverts commit 39dbcf6. * Revert "Aligning switch semantics with aria role (elastic#2193)" This reverts commit 76e58de. * CL
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Oct 22, 2019
thompsongl
added a commit
that referenced
this pull request
Oct 29, 2019
* Convert `EuiSwitch` to TS (#2243) * convert euiswitch to ts * remove test file * euiswitchevent; store id in state * change interface to type * CL * type for button * showLabel=false example * fix misc docs proptype warnings * reintroduce compressed and mini styles * another example * CL * cleanup * use p with aria-describedby * add click hanlder to p-label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems that the shimmed
onChangeevent type definition wasn't quite correct after the recent change from input to button. This converts the file to TS and creates a more backwards compatible event type.Question:
labelwas also recently changed to be required, but was previously optional. There are instances in Kibana without labels. Should it be required or not?Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes