-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suggest component #2270
Merged
Merged
Add Suggest component #2270
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
64b2e95
basic version works
andreadelrio 1e5d2c9
props descriptions
andreadelrio 259573e
added first basic version
andreadelrio 6f9bad3
added expandLongLabel
andreadelrio fe5f173
removed some quotes
andreadelrio fa19024
added some basic docs
andreadelrio 3185d9b
added layout to replace expandLongLabel
andreadelrio e23f429
tests passing
thompsongl 147487e
Merge pull request #1 from thompsongl/suggest-item
andreadelrio 4a2860f
placed suggestItem import and export in correct order
andreadelrio 0ab76c6
some css fixes
andreadelrio 9b4fdfa
changed the way 'status' is handled'
andreadelrio 1c39ecb
fixed typo and renamed variables
andreadelrio 091a19f
considering vis colors
andreadelrio 3e87f51
changes based on feedback
andreadelrio 08197bd
updated colors and added minor css changes
andreadelrio eb8e5e8
basic version works
andreadelrio 7ccf026
props descriptions
andreadelrio c21843b
added expandLongLabel
andreadelrio b68f805
removed some quotes
andreadelrio b582011
tests passing
thompsongl 418cba6
added layout to replace expandLongLabel
andreadelrio ac69d10
Merge pull request #1 from thompsongl/suggest-item
andreadelrio 7a0555b
placed suggestItem import and export in correct order
andreadelrio d850644
some css fixes
andreadelrio c0b57c7
considering vis colors
andreadelrio e6cabe4
changes based on feedback
andreadelrio 93f1e9b
updated colors and added minor css changes
andreadelrio 56e3751
Merge branch 'master' into suggest-item
andreadelrio 0a6f7c9
Merge branch 'suggest-item' of https://github.com/andreadelrio/eui in…
andreadelrio 4327708
added first basic version
andreadelrio 8966a7d
added some basic docs
andreadelrio bcc17b2
changed the way 'status' is handled'
andreadelrio aabbcfd
fixed typo and renamed variables
andreadelrio cfb4734
Merge branch 'suggest-item' into suggest-input
andreadelrio 065330f
might work on pattern soon
andreadelrio 18203eb
pattern base
andreadelrio 2994088
about to play with width
andreadelrio 6bcf6cc
added action and resize
andreadelrio 4de0870
added filters to pattern
andreadelrio b51ebd8
Merge remote-tracking branch 'upstream/master' into suggest-input
andreadelrio 18ac80b
working on pattern, need to update tests
andreadelrio 333affc
small update to test
andreadelrio e77c36a
Merge remote-tracking branch 'upstream/master' into suggest-input
andreadelrio ed3b256
added hashtag dropdown
andreadelrio 7596a44
suggestInput not expanding
andreadelrio d9b1abd
suggestInput now expands
andreadelrio cb3ac18
moving suggestions to suggestInput component
andreadelrio 81effa8
moved some things to component
andreadelrio 4c4b068
Merge remote-tracking branch 'upstream/master' into suggest-input
andreadelrio e2ed869
added inputPopover
andreadelrio 5fe49bf
removed pattern from Header
andreadelrio 0cd6c5a
hashtag dropdown save button not working
andreadelrio 41d453a
updated docs structure for suggest
andreadelrio dbeca43
Swapping for so consumer can pass down anything they want
435da7a
Merge pull request #2 from cchaos/suggest-input/appends
andreadelrio 6bb901c
passing input value to Suggest
andreadelrio 86c288a
Merge remote-tracking branch 'upstream/master' into suggest-input
andreadelrio 1825746
using the updated version of inputPopover
andreadelrio f450404
updated changelog
andreadelrio ea566ff
fixed cl conflict
andreadelrio 8187bbc
moved hashtagPopover to separate file
andreadelrio 8983e09
made suggestItem clickable
andreadelrio 9843357
updated tests
andreadelrio 746e0e8
renamed props and added snippet
andreadelrio c81b702
suggest item now uses the button tag
andreadelrio 1b5ec1b
renamed class
andreadelrio 0c59ec3
fixed conflicts
andreadelrio 62f6b0f
small fixes
andreadelrio fd7c070
fixed conflicts
andreadelrio de184ea
cleaned up onstructors and binding at definition
andreadelrio a5a5cf9
cl
andreadelrio e04a84d
cl
andreadelrio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
.savedQueriesInput__hideDatepicker { | ||
.euiSuperDatePicker__flexWrapper { | ||
width: 100%; | ||
|
||
> div:nth-of-type(1) { | ||
display: none; | ||
} | ||
} | ||
} | ||
|
||
.savedQueriesInput { | ||
padding-bottom: $euiSizeXL * 6; | ||
} | ||
|
||
.savedQueryManagement__text { | ||
padding: $euiSizeM $euiSizeM ($euiSizeM / 2); | ||
} | ||
|
||
.savedQueryManagement__listWrapper { | ||
// Addition height will ensure one item is "cutoff" to indicate more below the scroll | ||
max-height: $euiFormMaxWidth + $euiSize; | ||
overflow-y: hidden; | ||
} | ||
|
||
.savedQueryManagement__list { | ||
@include euiYScrollWithShadows; | ||
max-height: inherit; // Fixes overflow for applied max-height | ||
// Left/Right padding is calculated to match the left alignment of the | ||
// popover text and buttons | ||
padding: ($euiSizeM / 2) $euiSizeXS !important; // sass-lint:disable-line no-important | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandlerprall Should all the
state
s have been pulled out of the constructor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! This change is great to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL, thx