Added additional/base amount of z-index to popovers #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Sep 13, 2019
| @@ -458,7 +458,7 @@ export class EuiPopover extends Component<Props, State> { | |||
| const { zIndex: zIndexProp } = this.props; | |||
| const zIndex = | |||
| zIndexProp == null | |||
| ? getElementZIndex(this.button, this.panel) | |||
| ? getElementZIndex(this.button, this.panel) + 2000 | |||
There was a problem hiding this comment.
Smart that you used 2000, which matches $euiZContentMenu. I might add a comment just for folks so they know that's why you picked that number.
There was a problem hiding this comment.
Do we want this to be plus 2000 or at least 2000 ?
There was a problem hiding this comment.
I was thinking plus then it's alway overtop of any other content with the container as well. But I can see that this could get complicated with flyouts and modals both appearing at the same time?
But it should be at least 2000, and would still need to add a significant amount if the container is at least 2000 already.
There was a problem hiding this comment.
Alright, let's stick with +2000 and see how it goes :)
chandlerprall
approved these changes
Sep 17, 2019
cchaos
force-pushed
the
popover-zindex
branch
from
c818936 to
edeb264
Compare
This reverts commit 55bf446.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EuiPopover base z-index
The z-index is based off of the parent and the triggering element. But if both are
0, then so is the popover which causes anything with a z-index of1or more to show on top.Before
I've added an example in the File Picker docs section that will show:
Before
After
I'll remove this before merge but allows for easy testing.
And popovers in flyouts still work
Checklist
[ ] Checked in dark mode[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes