Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiColorStops] ignore empty values when getting range max and min #2496

Merged
merged 4 commits into from
Oct 28, 2019
Merged

[EuiColorStops] ignore empty values when getting range max and min #2496

merged 4 commits into from
Oct 28, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 28, 2019

Screen Shot 2019-10-28 at 12 30 45 PM

Notice when the input is an empty string and then the markers are all messed up. This is because getRangeMin and getRangeMax do not handle empty string values and can return NaN.

Screen Shot 2019-10-28 at 12 30 52 PM

@nreese nreese requested a review from thompsongl October 28, 2019 18:40
@nreese nreese merged commit b21509d into elastic:master Oct 28, 2019
@nreese nreese mentioned this pull request Oct 28, 2019
Closed
@thompsongl thompsongl mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nreese @thompsongl