-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed EuiSwitch
clicking on disabled label
#2575
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching and fixing this, @sulemanof
@@ -1,6 +1,6 @@ | |||
.euiSwitch { | |||
position: relative; | |||
display: inline-block; | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should remain as inline-block
. The display
property here hasn't changed recently, and there doesn't appear to be any regressions with layout.
The .euiSwitch__label
display
property should be inline
to match previous word wrapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there's an issue using the <p>
tag when placed inside of an EuiText block and have already started a PR to fix this. I'll fix the wrapping as well in that PR, so we can safely, for now, revert this display change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well. The display change was reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sulemanof!
@cchaos has text wrapping adjustments in #2585 that should address the same concerns you had with layout
Summary
This fixes the regression of
EuiSwitch
component:disabled
state if click on label:Found in kibana:
Using flex box it looks better:
Checklist