Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox: Sets focus back to the input element after each scroll #2589

Merged
merged 2 commits into from
Dec 3, 2019
Merged

EuiComboBox: Sets focus back to the input element after each scroll #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8dedf
Sets focus back to the input element after each scroll
ffknob Dec 3, 2019
82c1b8e
Adds PR number to CHANGELOG
ffknob Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
**Bug fixes**

- Fixed `EuiSwitch` clicking on disabled label ([#2575](https://github.com/elastic/eui/pull/2575))
- Fixed `EuiComboBox` options list closing when clicking outside the component after scrolling ([#2589](https://github.com/elastic/eui/pull/2589))

## [`16.1.0`](https://github.com/elastic/eui/tree/v16.1.0)

Expand Down
1 change: 1 addition & 0 deletions src/components/combo_box/__snapshots__/combo_box.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,7 @@ exports[`props singleSelection selects existing option when opened 1`] = `
onCloseList={[Function]}
onOptionClick={[Function]}
onOptionEnterKey={[Function]}
onScroll={[Function]}
optionRef={[Function]}
options={
Array [
Expand Down
1 change: 1 addition & 0 deletions src/components/combo_box/combo_box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ export class EuiComboBox extends Component {
fullWidth={fullWidth}
rootId={this.rootId}
onCloseList={this.closeList}
onScroll={() => this.searchInput.focus()}
/>
</EuiPortal>
);
Expand Down