[Icon] Update securityAnalyticsApp and logoSecurity #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
changed the title
cchaos
reviewed
Dec 9, 2019
Comment on lines
3
to
5
| <path class="euiIcon__fillNegative" fill="#535966" fill-rule="nonzero" d="M10,12 C15.4292399,12 19.8479317,16.3266708 19.9961582,21.7200952 L20,22 L20,23 L11,23 L11,32 L10,32 C4.4771525,32 0,27.5228475 0,22 C0,16.4771525 4.4771525,12 10,12 Z M9.00004872,21 L9.00004872,14.0618877 C5.05371356,14.5539641 2,17.9203656 2,22 C2,25.9928173 4.92512662,29.3024346 8.74934084,29.902813 L9.00004872,29.9381062 L9.00004872,14.0618877 L9.00004872,21 Z M11.0008913,14.0620049 L11,21 L17.9381062,21 C17.4976387,17.4677326 14.7543759,14.6506077 11.258042,14.0983496 L11.0008913,14.0620049 L11.0008913,14.0620049 Z"/> | ||
| <path fill="#00BFB3" fill-rule="nonzero" d="M26,22 C26,13.163444 18.836556,6 10,6 L10,8 C17.7319865,8 24,14.2680135 24,22 L26,22 Z"/> | ||
| <path fill="#00BFB3" fill-rule="nonzero" d="M32,22 C32,9.8497355 22.1502645,0 10,0 L10,2 C21.045695,2 30,10.954305 30,22 L32,22 Z"/> |
There was a problem hiding this comment.
These classes and fills are actually incorrect for this type of icon.
I will push up a commit that will optimize the svg's a bit and use the correct classes. Thanks for getting this started @patrykkopycinski.
cchaos
approved these changes
Dec 9, 2019
|
@cchaos nice! didn't know that, Thank you very much for help :) |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
You've got a approval and all the checks are passing, so you're good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements:
https://github.com/elastic/siem-team/issues/480
https://github.com/elastic/Design/issues/1846
Checklist