-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiErrorBoundary: converted to Typescript #2690
EuiErrorBoundary: converted to Typescript #2690
Conversation
One thing is, I couldn't convert the component to a Functional Component because React Hooks does not have a hook for |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@chandlerprall could you take a look if I got it all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good! Few last items from a final pass and this should be good to merge
- added a request around the
Error
interface - changelog entry needs to be moved back to the top section, as we just had a release which moved things around
- delete src/components/error_boundary/index.d.ts
- reference to the index.d.ts needs to be removed from
Line 4 in 3bf9df5
/// <reference path="./error_boundary/index.d.ts" />
Think I got it all |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last request - please export EuiErrorBoundaryProps
from src/components/error_boundary/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, pulled and tested locally
Thank you once again, @ffknob ! |
Summary
Closes #2661
Converted
EuiErrorBoundary
to Typescript.Checklist