-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate EuiFormRow to TypeScript #2712
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thanks @supergrecko for the contribution! Just a heads up, we are on break until after the new year so it will be a few weeks before we can get to reviewing your PR. |
@supergrecko I made a PR to your branch that shores-up the types and gets closer to EUI patterns: supergrecko/eui#1 Thanks for your help and patience! |
Cool, looked over the changes, makes sense. Thanks |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @supergrecko!
Summary
Closes #2654
Converted
EuiFormRow
to TypeScriptChecklist