Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate EuiFormRow to TypeScript #2712

Merged
merged 12 commits into from
Jan 16, 2020
Merged

Translate EuiFormRow to TypeScript #2712

merged 12 commits into from
Jan 16, 2020

Conversation

junlarsen
Copy link
Contributor

Summary

Closes #2654

Converted EuiFormRow to TypeScript

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@junlarsen junlarsen changed the title Euiformrow ts Translate EuiFormRow to TypeScript Dec 21, 2019
@cchaos
Copy link
Contributor

cchaos commented Dec 21, 2019

Thanks @supergrecko for the contribution! Just a heads up, we are on break until after the new year so it will be a few weeks before we can get to reviewing your PR.

@cchaos cchaos requested a review from chandlerprall January 2, 2020 18:03
@thompsongl
Copy link
Contributor

@supergrecko I made a PR to your branch that shores-up the types and gets closer to EUI patterns: supergrecko/eui#1

Thanks for your help and patience!

@junlarsen
Copy link
Contributor Author

@supergrecko I made a PR to your branch that shores-up the types and gets closer to EUI patterns: supergrecko#1

Thanks for your help and patience!

Cool, looked over the changes, makes sense. Thanks

@thompsongl
Copy link
Contributor

jenkins test this

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @supergrecko!

@thompsongl thompsongl merged commit 1b92b1b into elastic:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFormRow needs to be converted to TS
5 participants