Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining EuiFilterGroup items to TS #2761

Merged
merged 8 commits into from
Jan 17, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jan 15, 2020

Summary

Closes #2660. This should make converting some other remaining JS components easier.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs

- [ ] Added documentation examples

  • Added or updated jest tests

- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulled and tested locally.

@thompsongl thompsongl merged commit b5c0d47 into elastic:master Jan 17, 2020
@thompsongl thompsongl deleted the filtergroup-ts branch January 17, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFilterGroup needs to be converted to TS
2 participants